diff options
Diffstat (limited to 'README.md')
| -rw-r--r-- | README.md | 8 |
1 files changed, 5 insertions, 3 deletions
@@ -16,14 +16,16 @@ Development happens mainly on https://gitlab.poul.org/ If you're not a POuL member you can send patches directly to the maintainer (you can check the commit history for the email). -Here's how a contribution cycle should go: +Here's how a contribution cycle should happen: + 1. A review process starts only after an MR is open and marked as ready 2. There will be the usual discussion on the issues with the MR and suggestions on how to fix it. 3. A new iteration will be sent by the author. Improvements should not be built on top of the existing commits (unless making new ones make sense of course), instead the author is expected to amend the commits with the - changes required. This keeps the history clean for those who'll come after. + changes required and force pushing, effectively replacing the old commit + series. This keeps the history clean for those who'll come after. * Anyone is welcome to review (it is encouraged) * If the reviewer is not the maintainer then the reviewer will be given recognition through the `Reviewed-by` trailer. This is not only to give @@ -34,7 +36,7 @@ Here's how a contribution cycle should go: 6. The MR is merged ## Signoff -All commits should be signed-off. A sign off in this project certifies your +All commits have to be signed-off. A sign off in this project certifies your work under the [DCO](https://developercertificate.org/). By signing off you also declare that you understand and will adhere to the |